Skip to content

mingw-w64-v8: fix abseil MinGW thread-identity aliasing crash and enable Win32Waiter#38

Merged
jeroen merged 3 commits intomasterfrom
copilot/fix-mingw-w64-v8-bug
Apr 13, 2026
Merged

mingw-w64-v8: fix abseil MinGW thread-identity aliasing crash and enable Win32Waiter#38
jeroen merged 3 commits intomasterfrom
copilot/fix-mingw-w64-v8-bug

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 13, 2026

  • Analyzed root cause: abseil-cpp uses POSIX_SETSPECIFIC thread identity mode on MinGW causing thread identity aliasing crash
  • Created 017-abseil-mingw-thread-fixes.patchfixed: replaced malformed patch (wrong hunk offsets, bogus preamble) with a correct unified diff generated directly from the abseil-cpp source at the pinned commit (6d5ac0f); verified it applies cleanly with patch -p1
  • Updated PKGBUILD sha256sum for the corrected patch file
  • Committed and pushed

Copilot AI requested a review from jeroen April 13, 2026 19:30
@jeroen jeroen marked this pull request as ready for review April 13, 2026 19:32
@jeroen
Copy link
Copy Markdown
Contributor

jeroen commented Apr 13, 2026

@copilot your patch seems broken can you fix it please?

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 13, 2026

@copilot your patch seems broken can you fix it please?

Fixed in 39fd402. The previous patch file had incorrect hunk header line numbers and a bogus From: preamble that caused patch -p1 to fail. It's now replaced with a correct unified diff generated directly from the abseil-cpp source at the pinned commit (6d5ac0f), and the sha256sum in PKGBUILD has been updated to match.

@jeroen jeroen merged commit 1e2cd45 into master Apr 13, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants